Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static, const, extern C changes #5

Merged
merged 2 commits into from
May 9, 2014
Merged

Static, const, extern C changes #5

merged 2 commits into from
May 9, 2014

Conversation

ahippo
Copy link
Contributor

@ahippo ahippo commented May 9, 2014

Please, merge this pull request.
Thank you in advance!

ahippo added 2 commits May 9, 2014 06:49
@ahippo
Added static and const where appropriate.
4190772 
Marked internal functions as static not to export them and for compiler
to be able to optimize them more aggressively.
Placed data tables in .rodata section by declaring them static const.
@ahippo
Avoid explicit extern C while including ssw.h
d041406
@mengyao
Copy link
Owner

mengyao commented May 9, 2014

I have merged. Thank you for letting me know.

Bests,

Mengyao

On Jan 9, 2014, at 7:04 AM, Andrey Mazo notifications@github.com wrote:

Please, merge this pull request.
Thank you in advance!

You can merge this Pull Request by running

git pull https://github.com/ahippo/Complete-Striped-Smith-Waterman-Library master
Or view, comment on, or merge it at:

#5

Commit Summary

Added static and const where appropriate.
Avoid explicit extern C while including ssw.h
File Changes

M src/example.c (14)
M src/example.cpp (4)
M src/main.c (19)
M src/ssw.c (12)
M src/ssw.h (9)
M src/ssw_cpp.cpp (7)
Patch Links:

https://github.com/mengyao/Complete-Striped-Smith-Waterman-Library/pull/5.patch
https://github.com/mengyao/Complete-Striped-Smith-Waterman-Library/pull/5.diff
—
Reply to this email directly or view it on GitHub.

@mengyao mengyao merged commit d041406 into mengyao:master May 9, 2014
@ahippo
Copy link
Contributor Author

ahippo commented May 11, 2014

Thank you very much for merging this!

@mengyao
Copy link
Owner

mengyao commented May 12, 2014

You are welcome.

Thank you for helping to improve the library.

Bests,

Mengyao

On Jan 11, 2014, at 4:30 PM, Andrey Mazo notifications@github.com wrote:

Thank you very much for merging this!

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahippo @mengyao