[0.4.x] Ljson nan/null fixes #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple try/except pattern - try images then landmarks.
Now importing null values is correctly coerced to nan instead of None Also, added tests for this.
When serializing nan values from menpo, they should go down as null. When deserializing null values, they should be returned as nan.
patricksnape
pushed a commit
that referenced
this pull request
Feb 19, 2015
[0.4.x] Ljson nan/null fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate small fixes:
nanvalues was leavingnan, which is not officially supported by JSON. De-serializingnullvalues was causing an object array andnullwas serializing toNone. Now,nullwill de-serialize tonanfor landmarks andnanwill serialize tonull.