Balance out rescale/crop methods #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to create menpo images from things like scikit image or opencv
Not really a big changed since it is a private API anyway. Just for consistency.
This just makes the API more consistent around cropping to arbitrary pointclouds
|
@jabooth Happy with this? |
|
@patricksnape really happy with this, nice job. |
jabooth
added a commit
that referenced
this pull request
Jul 27, 2015
Balance out rescale/crop methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rounds out the image API with some extra methods:
rescale_to_reference_shaperescale_to_pointcloudcrop_to_pointcloudcrop_to_pointcloud_proportioninit_from_rolled_channels