New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance out rescale/crop methods #613

Merged
merged 3 commits into from Jul 27, 2015

Conversation

Projects
None yet
2 participants
@patricksnape
Contributor

patricksnape commented Jul 24, 2015

Rounds out the image API with some extra methods:

  • deprecate rescale_to_reference_shape
  • add rescale_to_pointcloud
  • add crop_to_pointcloud
  • add crop_to_pointcloud_proportion
  • add init_from_rolled_channels
  • tests

patricksnape added some commits Jul 24, 2015

Add new init_from_rolled_channels to image
This makes it easier to create menpo images from things like
scikit image or opencv
Make _str_shape a method since it calculates
Not really a big changed since it is a private API anyway. Just
for consistency.
Add new crop/rescale image methods for pclouds
This just makes the API more consistent around cropping to
arbitrary pointclouds
@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Jul 27, 2015

@jabooth Happy with this?

@jabooth

This comment has been minimized.

Member

jabooth commented Jul 27, 2015

@patricksnape really happy with this, nice job.
+1

jabooth added a commit that referenced this pull request Jul 27, 2015

Merge pull request #613 from patricksnape/image_methods
Balance out rescale/crop methods

@jabooth jabooth merged commit d642e3c into menpo:master Jul 27, 2015

4 checks passed

OS X MenpoBot Jenkins build passed No test results found.
Details
clahub All contributors have signed the Contributor License Agreement.
Details
continuous-integration/appveyor AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jabooth jabooth removed the in progress label Jul 27, 2015

@patricksnape patricksnape deleted the patricksnape:image_methods branch Sep 3, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment