Deprecate set_h_matrix and fix #677 #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Effectively disable it by not allowing setting of the h_matrix via the method by turning the immutable flag off. Therefore, removed a load of tests that were now effectively testing nothing.
This makes sure everything is fixed for the LK fitting in menpofit
|
@jabooth OK? |
|
+1 from me |
patricksnape
pushed a commit
that referenced
this pull request
Feb 17, 2016
Deprecate set_h_matrix and fix #677
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles #677 by deprecating
set_h_matrixand adding a test to make sure the bug @nontas was seeing in LK is now fixed.