New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow for forced inexact frame count in FFMpegVideoReader #716

Merged
merged 7 commits into from Aug 1, 2016

Conversation

Projects
None yet
4 participants
@san-bil
Contributor

san-bil commented Jul 27, 2016

Changes the behaviour of exact_frame_count in video importing so that if you set to False it just uses ffmpeg - this allows for much faster video ingestion.

Sanjay Bilakhia and others added some commits Jul 27, 2016

Add tests for new exact_frame_count logic
Now, if exact_frame_count is False, it will always prefer
the ffmpeg loading.
Swallow float n_components in PCA tests
Use integer division
@jabooth

This comment has been minimized.

Member

jabooth commented Jul 28, 2016

+1 from me, just need Bill to come back to life and we can get this in and make a minor release.
@patricksnape you happy with everything?

@menpobot

This comment has been minimized.

menpobot commented Jul 28, 2016

Can one of the admins verify this patch?

@patricksnape

This comment has been minimized.

Contributor

patricksnape commented Aug 1, 2016

Given it passes on travis and osx im just going to merge this for now - because we need the test fixes!

@patricksnape patricksnape merged commit c19bd2f into menpo:master Aug 1, 2016

1 of 2 checks passed

macOS MenpoBot Jenkins build started
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment