allow for forced inexact frame count in FFMpegVideoReader #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, if exact_frame_count is False, it will always prefer the ffmpeg loading.
Use integer division
Skip on Windows
|
+1 from me, just need Bill to come back to life and we can get this in and make a minor release. |
|
Can one of the admins verify this patch? |
|
Given it passes on travis and osx im just going to merge this for now - because we need the test fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the behaviour of
exact_frame_countin video importing so that if you set toFalseit just uses ffmpeg - this allows for much faster video ingestion.