add colorset support #32
Conversation
| name = colorDictionary.name.toLowerCase().trim().split(" ").join("_") | ||
| fileName = "#{name}.colorset" | ||
| colorsetURL = url.URLByAppendingPathComponent(fileName) | ||
| manager.createDirectoryAtPath_withIntermediateDirectories_attributes_error( |
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 81, max is 80.
|
|
||
| class ColorSetFormatter extends FormatterBase | ||
| # Asset Catalog Format Reference: Named Color Type https://developer.apple.com/library/content/documentation/Xcode/Reference/xcode_ref-Asset_Catalog_Format/Named_Color.html | ||
| # Asset catalog colors on Xcode 9 – Zeplin Gazette https://blog.zeplin.io/asset-catalog-colors-on-xcode-9-c4fdccc0381a |
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 120, max is 80.
| @@ -0,0 +1,59 @@ | |||
|
|
|||
| class ColorSetFormatter extends FormatterBase | |||
| # Asset Catalog Format Reference: Named Color Type https://developer.apple.com/library/content/documentation/Xcode/Reference/xcode_ref-Asset_Catalog_Format/Named_Color.html | |||
There was a problem hiding this comment.
Line exceeds maximum allowed length. Length is 174, max is 80.
|
|
||
| ColorSetFormatter.prototype.colorComponents = function(colorDictionary) { | ||
| var obj; | ||
| return obj = { |
There was a problem hiding this comment.
Did you mean to return a conditional instead of an assignment?
| "color-space": "display-p3", | ||
| components: this.colorComponents(colorDictionary) | ||
| }; | ||
| return obj = { |
There was a problem hiding this comment.
Did you mean to return a conditional instead of an assignment?
| ColorSetFormatter.prototype.contentsJSON = function(colorDictionary) { | ||
| var c, obj; | ||
| c = this.colorObject(colorDictionary); | ||
| return obj = { |
There was a problem hiding this comment.
Did you mean to return a conditional instead of an assignment?
There was a problem hiding this comment.
@houndci-bot @Adrxx
This JavaScript file is generated by coffee command, so IMO I think we developers don't need to have responsibility for it.
|
@Adrxx @lalomrtnz |
|
@griffin-stewie You're right, those comments are just annoying, I have removed the integration... |
|
Thank you for merging my PR. |
Xcode supports Named Color feature on Asset Catalog recently. I added export format for this for all iOS developers.
colorsetare bunch of JSON insideXXXXX.colorsetdirectories. I useEXPORT_TYPE_FILESto give users to chose destination directory for it.About
colorset