Fix resolve path #61
Merged
Fix resolve path #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening the current path component was done because the opened file could be used for a call to vfs_stat as well as vfs_readlink. However, a path may contain traversable directories which can not be opened with vfs_open because they are neither readable nor writeable. The following path /traversable/foo can not be resolved by uid 1000, if the traversable directory has the following permissions: d--x--x--x 1000 1000 traversable This is fixed by using vfs_fstat and the current absolute path to retrieve the attributes of the current path component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for all the followup fixes. Hopefully,
resolve_pathis now done for the foreseeable future.