Fix resolve_path infinite loop
#76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert vfs_open change of "In vfs_open, if the given path is an absolute one, do not try to resolve it, or we end up in an infinite loop of calls."
In 0c398e3 I changed the path resolution to not open all encountered path components, because directories do not need to be readable by the process to traverse them. Out of simplicity I erroneously changed the reading of the links from using the already opened path component to sys_readlink, which internally calls vfs_open causing an infinite loop. This is fixed by opening the link to read using vfs_open_abspath before calling vfs_readlink instead of sys_readlink to replace the current path component. Fixes: 0c398e3
|
Thank you very much, this is surely a cleaner solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #75, this reverts the change in
vfs_openand fixed the recursivevfs_opencall inresolve_path.Afterwards both
work fine.