Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timers and fix recursive call in vfs_open #75

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

Galfurian
Copy link
Member

  • Improve readability of timer code.
  • Fix bug with vfs_open, to avoid infinite call loop.

@Galfurian Galfurian merged commit f9679f2 into mentos-team:develop Apr 5, 2024
3 checks passed
@Galfurian Galfurian added the enhancement New feature or request label Apr 5, 2024
@Galfurian Galfurian changed the title Develop Improve timers and fix recursive call in vfs_open Apr 5, 2024
@Galfurian Galfurian added the bug Something isn't working label Apr 5, 2024
@fischerling
Copy link
Contributor

I think the vfs_open fix is not correct.

Absolute paths containing symlinks are no longer resolved when passing them to vfs_open.
open("/link/bar") with /link pointing to /foo will no longer resolved to /foo/bar.

This can be reproduced by running:

$ cat /user/home/README

@fischerling
Copy link
Contributor

fischerling commented Apr 5, 2024

I have a fix ready and will create created a new Pull Request.

See #76 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants