-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fstab fix #22
fstab fix #22
Conversation
Signed-off-by: David Greaves <david.greaves@jollamobile.com>
Signed-off-by: David Greaves <david.greaves@jollamobile.com>
…enmod and report if there's a problem Signed-off-by: David Greaves <david.greaves@jolla.com>
$(warning ********************* /boot appears to live on $(HYBRIS_BOOT_PART)) | ||
$(warning ********************* /data appears to live on $(HYBRIS_DATA_PART)) | ||
|
||
ifneq ($(words $(HYBRIS_BOOT_PART))$(words $(HYBRIS_DATA_PART)),11) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non string comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no - it's a string comparison.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was awaiting quote-marks ^_^
when building mako, now it says: Because /boot is in fstab.mako and in recovery.fstab . uniq? :) |
:( well sort -u does a uniq - but those 2 fields are not unique |
Oops pardon, it think those were still left-overs of my deliberate ramblings :) will double check in the morning |
@lbt, HADK testers proved this works (after cherry-picking). So merging. But e.g. motorola photon q (xt897) has not got recovery.fstab - and then perl script goes into infinite loop ( https://github.com/CyanogenMod/android_device_motorola_msm8960-common/tree/cm-10.1 , @flyser sourced it from https://raw.githubusercontent.com/SkrilaxCZ/android_device_moto_asanti_c/jellybean/recovery.fstab and then this perl script worked fine ) |
the infinite loop bug has finally a home: https://bugs.nemomobile.org/show_bug.cgi?id=777 |
Add support for read-only rootfs
No description provided.