Add support for configurable on/off values for binary led backend #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusa
reviewed
Jul 4, 2019
|
After thinking a while: For legacy static config stuff to go correctly, 'const char *' strings need to be used in structs - and config code then effectively needs to ignore the const part - lesser evil and so on. I'll try adding an explanatory comment somewhere... |
jusa
approved these changes
Jul 4, 2019
Currently only file paths can be defined in led backend configuration and the logic is ill suited for other types of data. Add support for defining generic string values. Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
spiiroin
force-pushed
the
mer1813_override_binary_on_off_values
branch
from
47a9ebf
to
d362b80
Compare
|
Review commits squashed |
|
Tested originally on a device that requires dynamic config -> missed that static config does not work. Fixed now. |
In some devices value that should be written to 'brightness' file when turning the led on has nothing to do with the value that is readable from 'max_brightness' file. Make it possible to configure values to use instead of 0/max_brightness. Signed-off-by: Simo Piiroinen <simo.piiroinen@jollamobile.com>
spiiroin
force-pushed
the
mer1813_override_binary_on_off_values
branch
from
d3ccf0a
to
8a289f2
Compare
|
Review commits squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.