Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depends on dbus service rather than socket #41

Closed
wants to merge 1 commit into from

Conversation

plfiorini
Copy link

With newer dbus depending on dbus.socket doesn't work and block the boot.

With newer dbus depending on dbus.socket doesn't work and block the boot.
@sledges
Copy link

sledges commented Nov 25, 2014

tested on jolla phone internal release candidate, no regressions

@mkosola
Copy link
Contributor

mkosola commented Nov 25, 2014

What do you mean by new dbus?

@plfiorini
Copy link
Author

The issue was reproduced with Maui that has dbus 1.8.6 (and in general newer packages of a lot of stuff including systemd), but sledges now tested this patch on Jolla and it doesn't appear to break anything.

@mkosola
Copy link
Contributor

mkosola commented Nov 25, 2014

Sensorfw is mer package and is designed to work with dbus and systemd from mer. There is a special dbus.socket to allow sensord start earlier than dbus.service. This will affect on boot order if we change this from .socket to .service

@@ -1,7 +1,7 @@
[Unit]
Description=Sensor daemon for sensor framework
After=boardname.service
Requires=dbus.socket
Requires=dbus.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this we should do probably Wants=dbus.service, then sensorfw could start before dbus.service is started and start initializing things. Yes, it blocks until dbus.service is up but that is the purpose as well, to allow different services to start side by side before others are ready to allow faster bootup.

@saukko
Copy link
Contributor

saukko commented Nov 25, 2014

Also we should add /usr/share/dbus-1/system-services/com.nokia.SensorService.service file that defines SystemdService=sensord.service among other things and in the systemd service file should define: BusName=com.nokia.SensorService

@mkosola
Copy link
Contributor

mkosola commented Dec 4, 2014

I created new pull req and it should fix this problem also:
#42

@lpotter
Copy link
Contributor

lpotter commented Dec 4, 2014

Are both of these needed?

@mkosola
Copy link
Contributor

mkosola commented Dec 8, 2014

No, this is not needed, only pull request #42

@mkosola
Copy link
Contributor

mkosola commented Dec 12, 2014

I'll close this, because pull req #42 is in

@mkosola mkosola closed this Dec 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants