Fix: Delete files that came with the Design System Starter, that I don't need yet. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meranicosme
changed the title
colbyallenc
reviewed
Sep 16, 2019
| @import "elements/ol-ul"; | ||
|
|
||
|
|
||
| // ===================================================================== | ||
| // 5. Objects | ||
| // Class-based selectors which define undecorated design patterns, | ||
| // for example media object known from OOCSS. | ||
| @import "object/grid"; | ||
| @import "object/width-limiter"; | ||
|
|
There was a problem hiding this comment.
I think some extra space snuck in here 😄
There was a problem hiding this comment.
got it. going to thumbs up stuff I fix
colbyallenc
reviewed
Sep 16, 2019
| @import "components/skip-to-content"; | ||
| @import "components/expandable-content"; | ||
| @import "components/icon"; | ||
|
|
There was a problem hiding this comment.
Lets get rid of that extra space 😄
colbyallenc
reviewed
Sep 16, 2019
colbyallenc
reviewed
Sep 17, 2019
| margin: 0; | ||
|
|
||
There was a problem hiding this comment.
a little bit of space snuck in here 😄
There was a problem hiding this comment.
this is alright. just made a space for the media query to go after
colbyallenc
reviewed
Sep 17, 2019
|
|
||
| <!-- <a href="/" class="drizzle-Nav-title">{{data "global.companyName"}} Design System</a> | ||
| <!-- <a href="/" class="drizzle-Nav-title">{{data "global.companyName"}} Design System</a> | ||
|
|
There was a problem hiding this comment.
I feel as though the indentation on this file was good in the original state but I could be wrong! Thoughts, @zastrow ?
might create these files as I go in the project
colbyallenc
force-pushed
the
drizzle-delete-folders
branch
from
f966c48
to
5f8eb4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
I made this branch to delete all the files I did not need that came with the Design System Starter repo. I ran npm start and it works. Let me know if there's anything I missed.
Here is my Invision link for the site design. :)