Added support for reading firmware version from WS90 #2517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support to read firmware version from the WS90.
zuckschwerdt
reviewed
Jun 2, 2023
src/devices/fineoffset_ws90.c
Outdated
| @@ -32,7 +32,7 @@ Preamble is aaaa aaaa aaaa, sync word is 2dd4. | |||
|
|
|||
| Packet layout: | |||
|
|
|||
| 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 | |||
| 0 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 ZZ 30 31 | |||
There was a problem hiding this comment.
This should be one line below, right? "29" and below "ZZ"
zuckschwerdt
reviewed
Jun 2, 2023
src/devices/fineoffset_ws90.c
Outdated
| @@ -131,6 +133,7 @@ static int fineoffset_ws90_decode(r_device *decoder, bitbuffer_t *bitbuffer) | |||
| "unknown", "Unknown", DATA_COND, unknown != 0x3fff, DATA_INT, unknown, | |||
| "rain_mm", "Total Rain", DATA_FORMAT, "%.1f mm", DATA_DOUBLE, rain_raw * 0.1f, | |||
| "supercap_V", "Supercap Voltage", DATA_COND, supercap_V != 0xff, DATA_FORMAT, "%.1f V", DATA_DOUBLE, supercap_V * 0.1f, | |||
| "firmware", "Firmware Version", DATA_FORMAT, "%d", DATA_INT, firmware, | |||
There was a problem hiding this comment.
Plain "%d" needs no format. Just ...Version", DATA_INT, ...
Fixed typos.
Fixed firmware type/format.
|
Looks great! Thanks! |
|
Some day I will get it correct the first time! ;-) |
|
Not needed ;) Nobody so far found that version field -- and you got that right for the first time :) |
jktjkt
added a commit
to jktjkt/rtl_433
that referenced
this pull request
Aug 2, 2023
This got garbled in the commit which added FW version discovery. Fixes: c94ee77 Change Fineoffset-WS90 to add firmware version (merbanan#2517)
andrewjw
pushed a commit
to andrewjw/rtl_433
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to read firmware version from the WS90.