Improve handling of units within HA UI #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
gdt
approved these changes
Aug 21, 2023
penfold42
pushed a commit
to penfold42/rtl_433
that referenced
this pull request
Aug 21, 2023
kcpants
pushed a commit
to kcpants/rtl_433
that referenced
this pull request
Aug 22, 2023
chpego
added a commit
to chpego/rtl_433
that referenced
this pull request
Sep 18, 2023
following on from PR merbanan#2607 , add device class illuminance
andrewjw
pushed a commit
to andrewjw/rtl_433
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By changing the device_class attribute to be "wind_speed" or "precipitation", this allows the lovelace UI in HomeAssistant to automatically do unit conversions through the UI. I tested these changes locally and they worked after removing the device from the MQTT integration and running this python script to re-preform the autodiscovery.
Valid device classes can be found here: https://www.home-assistant.io/integrations/sensor/#device-class