Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make target for downloading external dependencies #52

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

rustycl0ck
Copy link
Contributor

What this PR does / Why we need it

  • Add a single make target for downloading external dependencies/tools
  • Add clean target for removing locally downloaded files
  • Remove any unnecessary files which are no longer used in the project

The `tools` and the `skaffold` directories/files are no longer in use
and can be safely removed from the project.

Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
@rustycl0ck rustycl0ck requested a review from a team as a code owner November 12, 2021 02:17
@rustycl0ck rustycl0ck mentioned this pull request Nov 12, 2021
Copy link
Contributor

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tkuchiki tkuchiki merged commit 5d03fc5 into mercari:master Nov 16, 2021
@rustycl0ck rustycl0ck deleted the kpt branch January 28, 2022 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants