Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kpt package upgrade #43

Closed
wants to merge 6 commits into from
Closed

Conversation

rustycl0ck
Copy link
Contributor

What this PR does / Why we need it

Enable deployment through kpt

Which issue(s) this PR fixes

Fixes #41

NOTE: This PR depends on #40

rustycl0ck and others added 6 commits September 10, 2021 17:35
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
@rustycl0ck rustycl0ck requested a review from a team as a code owner September 17, 2021 08:08
@rustycl0ck rustycl0ck marked this pull request as draft September 17, 2021 08:09
@rustycl0ck
Copy link
Contributor Author

Converted to draft because it includes the changes from #40 too. Will be ready for review after #40 is merged.

@curl -Lso $(SKAFFOLD) https://storage.googleapis.com/skaffold/releases/$(shell cat .skaffold-version)/skaffold-$(GOOS)-$(GOARCH)
@chmod +x $(SKAFFOLD)

kpt: $(KPT)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self note:

  • Create make targets for kpt related actions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been implemented in #52, thus this PR an now be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade and fix broken kpt package files
1 participant