-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from command line flags to config file based options #77
Conversation
47f1b1d
to
37a3d16
Compare
@@ -18,9 +18,4 @@ spec: | |||
- "--v=10" | |||
ports: | |||
- containerPort: 8443 | |||
name: https | |||
- name: manager |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This conflicts with manager_config_patch.yaml so I removed it
- "--health-probe-bind-address=:8081" | ||
- "--metrics-bind-address=127.0.0.1:8080" | ||
- "--leader-elect" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ kustomize build config/default
...
---
apiVersion: v1
data:
controller_manager_config.yaml: |
apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
health:
healthProbeBindAddress: :8081
metrics:
bindAddress: 127.0.0.1:8080
webhook:
port: 9443
leaderElection:
leaderElect: true
resourceName: 54b82eb3.mercari.com
kind: ConfigMap
metadata:
name: spanner-autoscaler-manager-config
namespace: spanner-autoscaler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After reviewing @rustycl0ck, we'll merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Switch from command line flags to config file based options * Update config/default
What this PR does / Why we need it
Switched from command line flags to config file-based options.
https://book.kubebuilder.io/component-config-tutorial/tutorial.html
Which issue(s) this PR fixes
None
Steps to test the update