Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze Go version for golangci-lint #83

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

rustycl0ck
Copy link
Contributor

Latest version of Go (v1.18) breaks the golangci-lint versions <= v1.45

What this PR does / Why we need it

Fix the version of golang to v1.17 for golangci-lint workflow

Which issue(s) this PR fixes

Latest version of Go (v1.18) breaks the golangci-lint versions <= v1.45

Signed-off-by: rustyclock <rustyclock@protonmail.com>
@rustycl0ck rustycl0ck marked this pull request as ready for review April 11, 2022 01:22
@rustycl0ck rustycl0ck requested a review from a team as a code owner April 11, 2022 01:22
Copy link
Contributor

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustycl0ck rustycl0ck merged commit 2385cbb into mercari:master Apr 15, 2022
makew0rld added a commit to makew0rld/amfora that referenced this pull request Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants