Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For hot-deploying, support
lestrrat/go-server-starter
listeners.Graceful shutdown is done by Go1.8's graceful shutdown feature (see release note). So this PR must be merged after go1.8 release.
Test
To test hot-deploying feature, run
wbt
byserver-starter
and kill HUP to it constantly (per sec.) and send 1000 requests to check there is no lost requests.To kick
wbt
,To constantly kill HUP it,
Requests are done by
hey
command,$ hey -n 1000 -c 100 -D test.json -m POST 'http://localhost:8080/wbt'
The results are the followings. Sometimes requests takes long time (but very small number) but no requests are lost.