Implement static fields #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this includes parsing/writing, en-/decoding and a unit test... Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Michael Hahn <michael.hahn@mbition.io>
|
Please split the two commits in two PRs, it's too much to review changes from both at the same time |
kayoub5
reviewed
Mar 1, 2024
kayoub5
reviewed
Mar 1, 2024
done: #275. Thanks for the nudge. |
kayoub5
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements static fields, i.e., arrays of structures of fixed size. It includes parsing and writing, en- and decoding as well as a unit test.
Besides this, the PR does some janitorial work for
DiagDataDictionarySpec: It adds the missingadmin_dataattribute and it reorders all member attributes to the same order as the corresponding subtags in the XSD.Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information