Convert the parameter classes to the .from_et() pattern
#279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abstract base classes cannot be instantiated, yet we need to be able to do this in order to implement the `.from_et()` pattern with inheritance. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
kayoub5
reviewed
Mar 8, 2024
| raise ValueError( | ||
| f"A parameter of type {parameter_type} must reference a DOP! {dop_ref}, {dop_snref}" | ||
| ) | ||
|
|
||
| if parameter_type == "VALUE": |
There was a problem hiding this comment.
instead of multiple ifs, maybe use a lookup dict?
There was a problem hiding this comment.
that would make things harder to read and I doubt that the performance would be measurably better...
Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Florian Jost <florian.jost@mbition.io>
|
ok, let's merge this. Thanks for the review @kayoub5! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO this cleans up the parameter construction code significantly. On the flipside it requires to make the
Parameterclass instantiable...Andreas Lauser <andreas.lauser@mercedes-benz.com>, on behalf of MBition GmbH.
Provider Information