Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAR and ZIP files must be able to use data reference names without special treatment #1314

Closed
de-jcup opened this issue May 6, 2022 · 0 comments · Fixed by #1313
Closed
Assignees
Milestone

Comments

@de-jcup
Copy link
Member

de-jcup commented May 6, 2022

Situation

With #1098 we introduced the data configuration element which source an binary configuration elements have unique names which can be referenced.

Currently following is validated:

  • min length
  • max length
  • uniqueness inside model

But the names can be everything.

While writing documentation about data in

But currently they aren't! If we would use "~/" or "../.../" this would be very problematic...

Wanted

TAR and ZIP files must be able to use always the unique data reference names
without any encoding or escaping mechanism.

Solution

We simply add another validation to the sechub configuration model:
We only accept reference names which do contain a-z, 0-9, - or _

@de-jcup de-jcup added this to the Server 0.32.0 milestone May 6, 2022
@de-jcup de-jcup self-assigned this May 6, 2022
de-jcup added a commit that referenced this issue May 6, 2022
- changed model validation, inspect now for illegal characters
  accepted only now: `a-z`,`0-9`,`-` or `_`
- refactored existing parts from model validation: moved
  parts from  abstract simple string validation into
  simple string utils and reused implementation
- added some missing SPDX headers to sources
- added test scases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant