Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document data section #1218 #1313

Merged

Conversation

- replaced former open api model integrattion with more
  generic approach from #1149
- documented data section
- added webscan, licenscan and also code scan examples using
  data section.
- document open api reference example for web scans #1149
- changed model validation, inspect now for illegal characters
  accepted only now: `a-z`,`0-9`,`-` or `_`
- refactored existing parts from model validation: moved
  parts from  abstract simple string validation into
  simple string utils and reused implementation
- added some missing SPDX headers to sources
- added test scases
feature-1163-define-and-document-tar-zip-data-structure
feature-1163-define-and-document-tar-zip-data-structure
@de-jcup de-jcup requested a review from sven-dmlr May 6, 2022 16:04
@de-jcup de-jcup marked this pull request as ready for review May 6, 2022 16:04
Copy link
Member

@sven-dmlr sven-dmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; please check suggested changes.

- removed leading slash in content description examples
- added missing slash in documentation example
- fixed wrong reference namess in documentation examples
- minor changes (typos etc.)
@de-jcup de-jcup requested a review from sven-dmlr May 9, 2022 12:37
Copy link
Member

@sven-dmlr sven-dmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect now! :-)

@de-jcup de-jcup merged commit 7e2757b into develop May 9, 2022
@de-jcup de-jcup deleted the feature-1163-define-and-document-tar-zip-data-structure branch May 9, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants