Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename spring boot values / environment variables from "sechub.pds.*" to "pds.*" #1429

Closed
9 tasks done
company-jcup opened this issue Jun 24, 2022 · 1 comment · Fixed by #2325
Closed
9 tasks done

Rename spring boot values / environment variables from "sechub.pds.*" to "pds.*" #1429

company-jcup opened this issue Jun 24, 2022 · 1 comment · Fixed by #2325
Assignees
@de-jcup
Labels
configuration enhancement New feature or request
Milestone
PDS 1.0.0

Comments

@company-jcup
Copy link

company-jcup commented Jun 24, 2022 •
edited by de-jcup
Loading

Situation

Currently we have spring boot values with "sechub.pds.*"
It is not clear at a glimpse if the configuration is on SecHub or PDS side

Wanted

  • At PDS side we want only spring boot values starting with "pds.*"
  • If we have any special parts at SecHub side for the product executor, we still want to have those spring boot values starting with "sechub.pds*"
  • Executor config parameters for PDS side do always start with "pds.config.*"
  • Executor config parameters for PDS but on SecHub side do always start with "sechub.pds.config.*"

Solution

  • Collect changes inside this issue
  • Describe migration steps inside issue
  • Rename all relevant spring boot values on SecHub Side
  • Rename all relevant spring boot values on PDS Side
  • Rename all relevant parameter constants on SecHub Side
  • Rename all relevant parameter constants on PDS Side
  • Check/adapt Helm charts
  • Check/adapt run.sh scripts in container images
  • Check generated documentation
@de-jcup de-jcup mentioned this issue Apr 5, 2023
Open
@de-jcup de-jcup self-assigned this Jun 14, 2023
@de-jcup de-jcup added this to the Server 1.0.0 milestone Jun 14, 2023
@de-jcup de-jcup added enhancement New feature or request configuration labels Jun 14, 2023
de-jcup added a commit that referenced this issue Jun 14, 2023
@de-jcup
Renamed PDS spring boot values/env variables and parameters #1429
6ba4f89 
- pds_config.adoc changed all "sechub.pds" to "pds"
- replaced all "-Dsechub.pds" with "-Dpds"
- replaced all "SECHUB_PDS_" with "PDS_"
- replaced all `sechub.pds with `pds
- replaced in every *.adoc `sechub.pds` with `pds`
de-jcup added a commit that referenced this issue Jun 14, 2023
@de-jcup
Renamed PDS spring boot values/env variables and parameters #1429
9968051 
- replaced all `${sechub.pds` with `${pds`
- replaced in every `*.properties` all `sechub.pds` with `pds`
de-jcup added a commit that referenced this issue Jun 14, 2023
@de-jcup
Adopting yaml files to name changes #1429
3c35e91
@de-jcup de-jcup mentioned this issue Jun 14, 2023
Merged
@de-jcup
Copy link
Member

de-jcup commented Jun 14, 2023

Summary

What was done

Inside this issue following was done:

  • pds_config.adoc changed all "sechub.pds" to "pds"
  • replaced all "-Dsechub.pds" with "-Dpds"
  • replaced all "SECHUB_PDS_" with "PDS_"
  • replaced all sechub.pds with pds
  • replaced in every *.adoc sechub.pds with pds
  • replaced all ${sechub.pds with ${pds
  • replaced in every *.properties all sechub.pds with pds

At SecHub side we had already only "sechub.adapter.pds.*" which was not changed.

Migration steps for updating an existing SecHub infrastructure

  • in your executor configurations: change the parameters which start with "sechub.pds" to "pds"
  • in your IDE: change your launch configurations accordingly
    • "-Dsechub.pds." to "-Dpds."
    • Environment entries like "SECHUB_PDS_" to "PDS_"

de-jcup added a commit that referenced this issue Jun 15, 2023
@de-jcup
Renamed PDS spring boot values/env variables and parameters #1429
c60cb21 
- pds_config.adoc changed all "sechub.pds" to "pds"
- replaced all "-Dsechub.pds" with "-Dpds"
- replaced all "SECHUB_PDS_" with "PDS_"
- replaced all `sechub.pds with `pds
- replaced in every *.adoc `sechub.pds` with `pds`
de-jcup added a commit that referenced this issue Jun 15, 2023
@de-jcup
Renamed PDS spring boot values/env variables and parameters #1429
f223022 
- replaced all `${sechub.pds` with `${pds`
- replaced in every `*.properties` all `sechub.pds` with `pds`
de-jcup added a commit that referenced this issue Jun 15, 2023
@de-jcup
Adopting yaml files to name changes #1429
272d5e5
@de-jcup de-jcup mentioned this issue Jul 17, 2023
Closed
4 tasks
@sven-dmlr sven-dmlr modified the milestones: Server 1.0.0, PDS 1.0.0 Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
configuration enhancement New feature or request
Projects
None yet
Milestone
PDS 1.0.0
Development

Successfully merging a pull request may close this issue.

Feature 1429 rename values and variables for pds mercedes-benz/sechub
3 participants
@de-jcup @sven-dmlr @company-jcup