Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename pds.productexecutor.* to sechub.productexecutor.pds.* #2377

Closed
4 tasks done
de-jcup opened this issue Jul 17, 2023 · 0 comments · Fixed by #2378
Closed
4 tasks done

Rename pds.productexecutor.* to sechub.productexecutor.pds.* #2377

de-jcup opened this issue Jul 17, 2023 · 0 comments · Fixed by #2378
Assignees
@de-jcup
Labels
configuration enhancement New feature or request server
Milestone
Server 1.0.0

Comments

@de-jcup
Copy link
Member

de-jcup commented Jul 17, 2023 •
edited
Loading

Situation

With #1429 the PDSProductExecutorKeyConstants were not handled accordingly.

The constants inside look currently this way:

pds.productexecutor.*

Wanted

We want to have constants like
sechub.productexecutor.pds.* to make it clear that "this is on SecHub side"

Solution

Change the code parts:

  • PDSProductExecutorKeyConstants
  • SecHubProductExecutionPDSKeyProvider
  • *.adoc files containing pds.productexecutor.*
  • *.json files containing pds.productexecutor.*

Migration steps after release update

For a new deployment of SecHub server it is necessary to change the executor configurations from pds.productexecutor. to sechub.productexecutor.pds.*
@de-jcup de-jcup added this to the Server 1.0.0 milestone Jul 17, 2023
@de-jcup de-jcup self-assigned this Jul 17, 2023
@de-jcup de-jcup changed the title Rename parts inside PDSProductExecutorKeyConstants Rename pds.productexecutor.* to `sechub.productexecutor.pds.* Jul 17, 2023
@de-jcup de-jcup changed the title Rename pds.productexecutor.* to `sechub.productexecutor.pds.* Rename pds.productexecutor.* to sechub.productexecutor.pds.* Jul 17, 2023
de-jcup added a commit that referenced this issue Jul 17, 2023
@de-jcup
Renamed PDS product executor configuration entries on SecHub side #2377
6755e25 
- changed constants in PDSProductExecutorKeyConstants
  from "pds.productexecutor.*" to "sechub.productexecutor.pds.*"
  to make it clear, that this PDS information is only for SecHub
- updated getting started guide (.adoc)
- changed json files for SecHub solution
@de-jcup de-jcup mentioned this issue Jul 17, 2023
Merged
de-jcup added a commit that referenced this issue Jul 17, 2023
@de-jcup
Merge pull request #2378 from mercedes-benz/feature-2377-change-sechu…
a870148 
…b-productexecutor-pds-constants

Renamed PDS product executor configuration entries on SecHub side #2377
de-jcup added a commit that referenced this issue Aug 8, 2023
@de-jcup
Renamed PDS product executor configuration entries on SecHub side #2377
123982d 
- changed constants in PDSProductExecutorKeyConstants
  from "pds.productexecutor.*" to "sechub.productexecutor.pds.*"
  to make it clear, that this PDS information is only for SecHub
- updated getting started guide (.adoc)
- changed json files for SecHub solution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@de-jcup de-jcup

Labels
configuration enhancement New feature or request server
Projects
None yet
Milestone
Server 1.0.0
Development

Successfully merging a pull request may close this issue.

Renamed PDS product executor configuration entries on SecHub side #2377 mercedes-benz/sechub
1 participant
@de-jcup