Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore whitespaces when parsing github action scan types #3143

Closed
hamidonos opened this issue May 23, 2024 · 0 comments · Fixed by #3152
Closed

Ignore whitespaces when parsing github action scan types #3143

hamidonos opened this issue May 23, 2024 · 0 comments · Fixed by #3152
Labels
github-action
Milestone
GitHub action 2.1.0

Comments

@hamidonos
Copy link
Collaborator

hamidonos commented May 23, 2024 •
edited
Loading

Situation

When passing scan types as comma separated list with whitepaces the scan type is not correctly recognized because some scan types contain the whitespace

Wanted

scan-types: 'codeScan, secretScan' is parsed as ['codeScan', 'secretScan']

Solution

Sanitize the comma separated string
hamidonos added a commit that referenced this issue May 27, 2024
@hamidonos
sanitize github actions input strings #3143
b30b3ac
@hamidonos hamidonos mentioned this issue May 27, 2024
Closed
@sven-dmlr sven-dmlr added this to the GitHub action 2.1.0 milestone May 27, 2024
@hamidonos hamidonos mentioned this issue May 28, 2024
Merged
hamidonos added a commit that referenced this issue May 29, 2024
@hamidonos
Merge pull request #3152 from mercedes-benz/gha_feature-3143-sanitize…
095b7ae 
…-github-actions-input-strings

sanitize github actions input strings #3143
@sven-dmlr sven-dmlr mentioned this issue Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github-action
Projects
None yet
Milestone
GitHub action 2.1.0
2 participants
@sven-dmlr @hamidonos