Feature 633 admin can change email address of user #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce new Usecase
- annotation `UseCaseAdminUpdatesUserEmailAddress`
- usecase identifier `UC_ADMIN_UPDATES_USER_EMAIL_ADDRESS`
- documentation via asciidoc + annotation data
- Introduce new event/domain message
- MessageID
- MessageDataKey
- enhanced UserMessage, contains now former email address (optional)
- Implemented Logic
- introducing new service `UserEmailAddressUpdateService`
- Role allowed: only admin
- added unit tests for service
- Add REST access
- introduced new method inside UserAdministrationRestController
- Role allowed: only admin
- additional (but not related)
- introducing TestCanaryException, so easier to check
exception handling
- Test API changes
- added new method inside TestURLbuilder for new rest call
- added new test call method inside class `AsUser`
to make it callable inside integration test
- Integration test
- wrote test which does change as an administrator an existing
user.
- checks if user email address has been changed
- checks if an email was sent to new user email address
- checks if an email was sent to old user email address
Additional (because necessary):
- TestAPI changes
- added test user detail information to fetch old email address
from user for testing
- changed AssertEmail and introduced TextSearchmode
- introduced `UserEmailAddressChangedNotificationService` - added tests to check mail content and subjects are correct created - changed integration test - email subject text a little bit different Additional - same smaller changes at update service - MockEmailAccess improved error output, contains now text search mode info
- applied source formatting by spotless - fixed failing unit test - added missing SPDX header related to #633
- added simple DAUI action to change email address for user - added missing method in `DeveloperAdministration` class - added new action inside `CommandUI`
winzj
requested changes
Feb 21, 2022
...ntegrationtest/src/main/java/com/mercedesbenz/sechub/integrationtest/api/TextSearchMode.java
Outdated
Show resolved
Hide resolved
- fixed typo in emum
de-jcup
deleted the
feature-633-admin-can-change-email-address-of-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This PR is now mentioned as an example in our wiki:
https://github.com/mercedes-benz/sechub/wiki/FAQ#is-there-a-good-example-issue-for-new-contributors
Each commit contains detailed messages about a specific work done at the commit.
The feature (#633) itself seams to be very easy to implement (at a first glance..), but implementation handled much aspects from SecHub internals:
administrationsends an event which is handled bynotificationdomain)Details about architecture aspects are described at https://mercedes-benz.github.io/sechub/latest/sechub-architecture.html
For some specific technical details please read https://mercedes-benz.github.io/sechub/latest/sechub-techdoc.html