Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 633 admin can change email address of user #1029

Merged
merged 7 commits into from
Feb 21, 2022

Commits on Feb 18, 2022

  1. Introduce new admin usecase "change user email address" #633

    - Introduce new Usecase
      - annotation `UseCaseAdminUpdatesUserEmailAddress`
      - usecase identifier `UC_ADMIN_UPDATES_USER_EMAIL_ADDRESS`
      - documentation via asciidoc + annotation data
    - Introduce new event/domain message
      - MessageID
      - MessageDataKey
      - enhanced UserMessage, contains now former email address (optional)
    - Implemented Logic
      - introducing new service `UserEmailAddressUpdateService`
      - Role allowed: only admin
      - added unit tests for service
    - Add REST access
     - introduced new method inside UserAdministrationRestController
     - Role allowed: only admin
    
    - additional (but not related)
      - introducing TestCanaryException, so easier to check
        exception handling
    de-jcup committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    b8996a8 View commit details
    Browse the repository at this point in the history
  2. Integration test #633

    - Test API changes
      - added new method inside TestURLbuilder for new rest call
      - added new test call method inside class `AsUser`
        to make it callable inside integration test
    - Integration test
      - wrote test which does change as an administrator an existing
        user.
      - checks if user email address has been changed
      - checks if an email was sent to new user email address
      - checks if an email was sent to old user email address
    
    Additional (because necessary):
    - TestAPI changes
      - added test user detail information to fetch old email address
        from user for testing
      - changed AssertEmail and introduced TextSearchmode
    de-jcup committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    687c26c View commit details
    Browse the repository at this point in the history
  3. Implement notifications #633

    - introduced `UserEmailAddressChangedNotificationService`
    - added tests to check mail content and subjects are correct
      created
    
    - changed integration test
      - email subject text a little bit different
    
    Additional
    - same smaller changes at update service
    - MockEmailAccess improved error output, contains now text search
      mode info
    de-jcup committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    34805f0 View commit details
    Browse the repository at this point in the history
  4. Added missing RESTDIC test #633

    de-jcup committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    f9498e7 View commit details
    Browse the repository at this point in the history
  5. Some minor changes #633

    - applied source formatting by spotless
    - fixed failing unit test
    - added missing SPDX header related to #633
    de-jcup committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    663c111 View commit details
    Browse the repository at this point in the history
  6. Introduce DAUI action to change email address #633

    - added simple DAUI action to change email address for user
    - added missing method in `DeveloperAdministration` class
    - added new action inside `CommandUI`
    de-jcup committed Feb 18, 2022
    Configuration menu
    Copy the full SHA
    daa5005 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. Review changes #633

    - fixed typo in emum
    de-jcup committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    33654fb View commit details
    Browse the repository at this point in the history