-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature 633 admin can change email address of user #1029
Merged
de-jcup
merged 7 commits into
develop
from
feature-633-admin-can-change-email-address-of-user
Feb 21, 2022
Merged
Feature 633 admin can change email address of user #1029
de-jcup
merged 7 commits into
develop
from
feature-633-admin-can-change-email-address-of-user
Feb 21, 2022
Commits on Feb 18, 2022
-
Introduce new admin usecase "change user email address" #633
- Introduce new Usecase - annotation `UseCaseAdminUpdatesUserEmailAddress` - usecase identifier `UC_ADMIN_UPDATES_USER_EMAIL_ADDRESS` - documentation via asciidoc + annotation data - Introduce new event/domain message - MessageID - MessageDataKey - enhanced UserMessage, contains now former email address (optional) - Implemented Logic - introducing new service `UserEmailAddressUpdateService` - Role allowed: only admin - added unit tests for service - Add REST access - introduced new method inside UserAdministrationRestController - Role allowed: only admin - additional (but not related) - introducing TestCanaryException, so easier to check exception handling
Configuration menu - View commit details
-
Copy full SHA for b8996a8 - Browse repository at this point
Copy the full SHA b8996a8View commit details -
- Test API changes - added new method inside TestURLbuilder for new rest call - added new test call method inside class `AsUser` to make it callable inside integration test - Integration test - wrote test which does change as an administrator an existing user. - checks if user email address has been changed - checks if an email was sent to new user email address - checks if an email was sent to old user email address Additional (because necessary): - TestAPI changes - added test user detail information to fetch old email address from user for testing - changed AssertEmail and introduced TextSearchmode
Configuration menu - View commit details
-
Copy full SHA for 687c26c - Browse repository at this point
Copy the full SHA 687c26cView commit details -
- introduced `UserEmailAddressChangedNotificationService` - added tests to check mail content and subjects are correct created - changed integration test - email subject text a little bit different Additional - same smaller changes at update service - MockEmailAccess improved error output, contains now text search mode info
Configuration menu - View commit details
-
Copy full SHA for 34805f0 - Browse repository at this point
Copy the full SHA 34805f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9498e7 - Browse repository at this point
Copy the full SHA f9498e7View commit details -
- applied source formatting by spotless - fixed failing unit test - added missing SPDX header related to #633
Configuration menu - View commit details
-
Copy full SHA for 663c111 - Browse repository at this point
Copy the full SHA 663c111View commit details -
Introduce DAUI action to change email address #633
- added simple DAUI action to change email address for user - added missing method in `DeveloperAdministration` class - added new action inside `CommandUI`
Configuration menu - View commit details
-
Copy full SHA for daa5005 - Browse repository at this point
Copy the full SHA daa5005View commit details
Commits on Feb 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 33654fb - Browse repository at this point
Copy the full SHA 33654fbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.