Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typescript SDK patch entity with multiple files fileIndex remains 0 #284

Closed
Amtron opened this issue Jan 6, 2020 · 1 comment
Closed

typescript SDK patch entity with multiple files fileIndex remains 0 #284

Amtron opened this issue Jan 6, 2020 · 1 comment
Assignees
@DanielCollins

Comments

@Amtron
Copy link
Collaborator

Amtron commented Jan 6, 2020

tested this out on job.clientFiles:
create 2 new Merchi files and add them to the job.clientFiles.
Do job.save; the first file will be created and linked with the job twice.
This is because the fileIndex in ./typescript/src/entity.ts on line 598 isn't being incremented.
@DanielCollins
Copy link
Contributor

@Amtron maybe assign someone

@Amtron Amtron mentioned this issue Jan 6, 2020
Closed
DanielCollins added a commit that referenced this issue Jan 6, 2020
@DanielCollins
fix non-incrementing fileIndex in typescript sdk. closes #284
39bc2d8
@Amtron Amtron closed this as completed in d8d5af5 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielCollins DanielCollins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DanielCollins @Amtron