Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra path in .sha256 #209

Closed
bgklc opened this issue Oct 28, 2021 · 2 comments
Closed

extra path in .sha256 #209

bgklc opened this issue Oct 28, 2021 · 2 comments

Comments

@bgklc
Copy link

bgklc commented Oct 28, 2021

sudo ./skulls.sh -b x230
does not find .sha256. If I remove skulls-1.0.3/ from x230_coreboot_seabios_45ce84113e_top.rom.sha256 it works smoothly.

@yubiuser
Copy link
Contributor

I think the issue is here

skulls/release.sh

Lines 200 to 211 in 6e29604

RELEASE_IMAGE_FILE=$(basename "${RELEASE_IMAGE}")
sha256sum ${RELEASE_DIR}/${RELEASE_IMAGE_FILE} > "${RELEASE_DIR}/${RELEASE_IMAGE_FILE}.sha256"
RELEASE_IMAGE_FILE_2=$(basename "${RELEASE_IMAGE_2}")
sha256sum ${RELEASE_DIR}/${RELEASE_IMAGE_FILE_2} > "${RELEASE_DIR}/${RELEASE_IMAGE_FILE_2}.sha256"
RELEASE_IMAGE_FILE_3=$(basename "${RELEASE_IMAGE_3}")
sha256sum ${RELEASE_DIR}/${RELEASE_IMAGE_FILE_3} > "${RELEASE_DIR}/${RELEASE_IMAGE_FILE_3}.sha256"
RELEASE_IMAGE_FILE_4=$(basename "${RELEASE_IMAGE_4}")
sha256sum ${RELEASE_DIR}/${RELEASE_IMAGE_FILE_4} > "${RELEASE_DIR}/${RELEASE_IMAGE_FILE_4}.sha256"
RELEASE_IMAGE_FILE_5=$(basename "${RELEASE_IMAGE_5}")
sha256sum ${RELEASE_DIR}/${RELEASE_IMAGE_FILE_5} > "${RELEASE_DIR}/${RELEASE_IMAGE_FILE_5}.sha256"
RELEASE_IMAGE_FILE_6=$(basename "${RELEASE_IMAGE_6}")
sha256sum ${RELEASE_DIR}/${RELEASE_IMAGE_FILE_6} > "${RELEASE_DIR}/${RELEASE_IMAGE_FILE_6}.sha256"

sha256sum is invoked with the complete path of ${RELEASE_DIR} which then gets printed in the output. One solution would be to change into ${RELEASE_DIR} before and execute sha256sum only on $(basename "${RELEASE_IMAGE}") without the path.

@henning-schild
Copy link

Just wanted to report the same, the fix and the "blame" on recent release script changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants