Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to split conditions different validators in separate checks #225

Closed
Jackenmen opened this issue Aug 12, 2019 · 2 comments · Fixed by #297
Closed

Allow to split conditions different validators in separate checks #225

Jackenmen opened this issue Aug 12, 2019 · 2 comments · Fixed by #297
Assignees

Comments

@Jackenmen
Copy link

One GitHub app can create multiple checks, so it would be nice if mergeable would support this (unless it does and I just don't know how set it up then I'll be thankful for any tips)

image

@shine2lay
Copy link
Member

shine2lay commented Aug 14, 2019

@jack1142 Currently we can't do this yet and this is only because context between each When: 'event' is shared. After we add logic to run each When in it's own context, this will be available by doing something like this.

- When : 'pull_request.*'
    validate: # First ruleset 
    pass: 
      do: checks # first check
- When : 'pull_request.*'
    validate: # Second ruleset
    pass:
      do: checks # second check

@shine2lay
Copy link
Member

I've been doing a bit of research on this, it seems we'll need to provide different 'name' in the checks in order to create separate checks, otherwise they get overwritten. what do you think about adding a name field for each when @jusx ?

@shine2lay shine2lay self-assigned this Apr 5, 2020
shine2lay added a commit to shine2lay/mergeable that referenced this issue May 6, 2020
shine2lay added a commit that referenced this issue May 6, 2020
feat: ability to create multiple checks
shine2lay added a commit that referenced this issue May 20, 2020
feat: allow approvals to be limited to team members
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants