Fix Rails 5 sash validation fail because of required belong_to

[tamycova]

#265

It fails when I use rake to test, but works on my Rails 5 app. Also the line is over 80 characters but wasn't sure how do you prefer to break the line.

[houndci-bot]

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Line is too long. [82/80]

[tute]

Looking good! This will need a conditional for the Rails major version, though.

Can you please add - RAILS_VERSION=4.2 to the .travis.yml file, to make sure it continues to work on that version? I don't know why 4.2 is not being built in Travis anymore. Then we will see the following error for that version:

activesupport-4.2.6/lib/active_support/core_ext/hash/keys.rb:75:in `block in assert_valid_keys': Unknown key: :optional. Valid keys are: :class_name, :anonymous_class, :foreign_key, :validate, :autosave, :dependent, :primary_key, :inverse_of, :required, :foreign_type, :polymorphic, :touch, :counter_cache (ArgumentError)

We should address that, and have it tested.

Thanks!

[tute]

Also, a regression spec for your failing User.create is a good addition for this PR. Thanks so much!

[tamycova]

Will do!

[tute]

ping @tamycova. Thanks!

[tute]

If you need help, please share your questions and I'll do my best.

[louisdb03]

I'm having the same issue here, how do I implement the fix? Or when is the update comming? :)

[tute]

I'm having the same issue here, how do I implement the fix?

This works only in Rails 5. You can freely use this branch in your project and it will work.

Or when is the update comming? :)

When someone invests the time to make merit work with both versions, and tests both versions in Travis. Then I'll release it.

Thanks!

[louisdb03]

Hi, I'm very sorry to ask you this but how do I know the name of the branch? :p I tried this but no succes: gem 'merit', :branch => 'f657596409d98fc7c8e3274b213b86cc47d87495' Grts , Louis 2016-12-04 20:59 GMT+01:00 Tute Costa <notifications@github.com>:

…

I'm having the same issue here, how do I implement the fix? This works only in Rails 5. You can freely use this branch in your project and it will work. Or when is the update comming? :) When someone invests the time to make merit work with both versions, and tests both versions in Travis. Then I'll release it. Thanks! — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#266 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ARN9J74GItR8B4cgZ8gGIdke86q-wNU1ks5rExutgaJpZM4Ko4B0> .

-- Louis De Beule Division VZW GSM: +32 494 84 68 28

[tute]

You could do gem 'merit', github: "tamycova/merit", branch: 'f657596409d98fc7c8e3274b213b86cc47d87495'

[tute]

I find it surprising, but it looks like CI is passing for Rails 5: https://travis-ci.org/merit-gem/merit/builds/159191419. Closing this issue, but if it continues to be a problem we reopen.
Thanks for sharing your work! 😃 👏

[wa0x6e]

Hello,

I'm having the same issue, using the fix in this PR did fix the issue, belongs_to do require the optional option.

I am not sure as I didn't read through the whole test code, but the reason the CI is passing on Rails 5 without that patch is because that precise use case (creating a basic user with has_merit) is not tested.

[tute]

I am not sure as I didn't read through the whole test code, but the reason the CI is passing on Rails 5 without that patch is because that precise use case (creating a basic user with has_merit) is not tested.

On Rails 5, doing User.create! in master's test suite works well. If you have a regression test, please copy it here, or submit it in the form of a PR.

Thanks!

[mrsweaters]

@tute I'm getting the Sash must exist error on User.create! in Rails 5.1.4 as well.

[mrsweaters]

I just tested against @tamycova's update and it fixes the issue.

[Velora]

I have the same issue with Rails 5 and belongs_to :sash, class_name: 'Merit::Sash', inverse_of: nil, optional: true would also fix it for me.

This might not be the preferred solution, but for some it might also be possible that they set the following config to false to have the same behavior that was default in Rails 4: Rails.application.config.active_record.belongs_to_required_by_default = false

[ronyfhebrian]

I have tried all your ways but I still have error, what should I do?