fix: bigint is a number literal

closes #136
meriyah · Oct 28, 2020 · 2ad1a27 · 2ad1a27
1 parent 9504b6a
commit 2ad1a27
Show file tree

Hide file tree

Showing 4 changed files with 104 additions and 3 deletions.
diff --git a/src/parser.ts b/src/parser.ts
@@ -4452,13 +4452,13 @@ export function parseBigIntLiteral(
       ? {
           type: 'Literal',
           value: tokenValue,
-          bigint: tokenRaw.substring(0, tokenRaw.length - 1), // without the ending "n"
+          bigint: tokenRaw.slice(0, -1), // without the ending "n"
           raw: tokenRaw
         }
       : {
           type: 'Literal',
           value: tokenValue,
-          bigint: tokenRaw.substring(0, tokenRaw.length - 1) // without the ending "n"
+          bigint: tokenRaw.slice(0, -1) // without the ending "n"
         }
   );
 }
@@ -4721,6 +4721,10 @@ export function parseIdentifier(parser: ParserState, context: Context, isPattern
  */
 export function parseLiteral(parser: ParserState, context: Context): ESTree.Literal {
   const { tokenValue, tokenRaw, tokenPos, linePos, colPos } = parser;
+  if (parser.token === Token.BigIntLiteral) {
+    return parseBigIntLiteral(parser, context, tokenPos, linePos, colPos);
+  }
+
   nextToken(parser, context);
   parser.assignable = AssignmentKind.CannotAssign;
   return finishNode(

diff --git a/src/token.ts b/src/token.ts
@@ -176,7 +176,7 @@ export const enum Token {
 
   // Stage #3 proposals
   PrivateName        = 121,
-  BigIntLiteral      = 122,
+  BigIntLiteral      = 122 | IsExpressionStart | IsStringOrNumber,
   Coalesce           = 123 | IsBinaryOp | IsCoalesc | 1 << PrecStart, // ??
   QuestionMarkPeriod = 124 | IsMemberOrCallExpression, // ?.
 

diff --git a/test/parser/expressions/class.ts b/test/parser/expressions/class.ts
@@ -12634,6 +12634,51 @@ describe('Expressions - Class', () => {
         sourceType: 'script',
         type: 'Program'
       }
+    ],
+    [
+      `class A { [1n](){} }`,
+      Context.None,
+      {
+        body: [
+          {
+            body: {
+              body: [
+                {
+                  computed: true,
+                  key: {
+                    bigint: '1',
+                    type: 'Literal',
+                    value: 1n
+                  },
+                  kind: 'method',
+                  static: false,
+                  type: 'MethodDefinition',
+                  value: {
+                    async: false,
+                    body: {
+                      body: [],
+                      type: 'BlockStatement'
+                    },
+                    generator: false,
+                    id: null,
+                    params: [],
+                    type: 'FunctionExpression'
+                  }
+                }
+              ],
+              type: 'ClassBody'
+            },
+            id: {
+              name: 'A',
+              type: 'Identifier'
+            },
+            superClass: null,
+            type: 'ClassDeclaration'
+          }
+        ],
+        sourceType: 'script',
+        type: 'Program'
+      }
     ]
   ]);
 });
diff --git a/test/parser/expressions/object.ts b/test/parser/expressions/object.ts
@@ -26630,6 +26630,58 @@ describe('Expressions - Object', () => {
           }
         ]
       }
+    ],
+    [
+      '({1n:1})',
+      Context.OptionsRanges,
+      {
+        sourceType: 'script',
+        start: 0,
+        type: 'Program',
+        body: [
+          {
+            end: 8,
+            expression: {
+              end: 7,
+              properties: [
+                {
+                  computed: false,
+                  end: 6,
+                  key: {
+                    bigint: '1',
+                    end: 4,
+                    range: [2, 4],
+                    start: 2,
+                    type: 'Literal',
+                    value: 1n
+                  },
+                  kind: 'init',
+                  method: false,
+                  range: [2, 6],
+                  shorthand: false,
+                  start: 2,
+                  type: 'Property',
+                  value: {
+                    end: 6,
+                    range: [5, 6],
+                    start: 5,
+                    type: 'Literal',
+                    value: 1
+                  }
+                }
+              ],
+              range: [1, 7],
+              start: 1,
+              type: 'ObjectExpression'
+            },
+            range: [0, 8],
+            start: 0,
+            type: 'ExpressionStatement'
+          }
+        ],
+        end: 8,
+        range: [0, 8]
+      }
     ]
   ]);
 });