BigInt should be allowed to use as object key

[fisker]

require('meriyah').parse('{1n:1n}',{next:true})
Uncaught [ParseError [SyntaxError]: [1:4]: Unexpected token: ':'
] {
  index: 4,
  line: 1,
  column: 4,
  description: "[1:4]: Unexpected token: ':'",
  loc: { line: 1, column: 4 }
}

console.log({1n:1})
{ '1': 1 }

[3cp]

What's your node/browser version?

⋊> ~/g/meriyah on jsx-fix ⨯ node
Welcome to Node.js v12.18.3.
Type ".help" for more information.
> console.log({1n:1})
console.log({1n:1})
             ^^

Uncaught SyntaxError: Unexpected number

[3cp]

node v15 works.

[KFlash]

It's a valid case. BigInt can be a property key. Also for Class

[3cp]

I see where is missed.

} else if ((parser.token & Token.IsStringOrNumber) === Token.IsStringOrNumber) {
        key = parseLiteral(parser, context);

Our Token.IsStringOrNumber only applies to string and number, not bigint.
Should I add bigint to Token.IsStringOrNumber?

ecma spec seems indicating bigint can be used anywhere a normal number fits.

NumericLiteral::
  DecimalLiteral
  DecimalBigIntegerLiteral
  NonDecimalIntegerLiteral
  NonDecimalIntegerLiteralBigIntLiteralSuffix

[KFlash]

Yes. It's easy to update token.ts

[3cp]

also need to update parseLiteral to check bigint.

[KFlash]

why? How do you parse BigInt now? Just check for "if (token === Token.BigInt") return parseBigInt)

[3cp]

yes, I am adding the line to parseLiteral, if you add the line outside of parseLiteral, you need to add it in many places after Token.IsStringOrNumber check.