Skip to content

Commit

Permalink
fix(jsx): fix missing raw for JSXAttribute.value
Browse files Browse the repository at this point in the history
closes #128
  • Loading branch information
3cp committed Oct 27, 2020
1 parent 076e454 commit bbd8b8a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
5 changes: 3 additions & 2 deletions src/lexer/jsx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export function scanJSXAttributeValue(parser: ParserState, context: Context): To
parser.startLine = parser.linePos = parser.line;
parser.token =
CharTypes[parser.currentChar] & CharFlags.StringLiteral
? scanJSXString(parser)
? scanJSXString(parser, context)
: scanSingleToken(parser, context, LexerState.None);
return parser.token;
}
Expand All @@ -27,7 +27,7 @@ export function scanJSXAttributeValue(parser: ParserState, context: Context): To
*
* @param parser The parser object
*/
export function scanJSXString(parser: ParserState): Token {
export function scanJSXString(parser: ParserState, context: Context): Token {
const quote = parser.currentChar;
let char = advanceChar(parser);
const start = parser.index;
Expand All @@ -40,6 +40,7 @@ export function scanJSXString(parser: ParserState): Token {
if (char !== quote) report(parser, Errors.UnterminatedString);
parser.tokenValue = parser.source.slice(start, parser.index);
advanceChar(parser); // skip the quote
if (context & Context.OptionsRaw) parser.tokenRaw = parser.source.slice(parser.tokenPos, parser.index);
return Token.StringLiteral;
}

Expand Down
3 changes: 2 additions & 1 deletion test/parser/miscellaneous/jsx.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1747,7 +1747,7 @@ describe('Miscellaneous - JSX', () => {
],
[
`<div id={aa} class="className" ></div>`,
Context.OptionsJSX | Context.OptionsRanges | Context.OptionsLoc,
Context.OptionsJSX | Context.OptionsRanges | Context.OptionsLoc | Context.OptionsRaw,
{
type: 'Program',
sourceType: 'script',
Expand Down Expand Up @@ -1848,6 +1848,7 @@ describe('Miscellaneous - JSX', () => {
value: {
type: 'Literal',
value: 'className',
raw: '"className"',
start: 19,
end: 30,
range: [19, 30],
Expand Down

0 comments on commit bbd8b8a

Please sign in to comment.