Fix Markdown parsing, add more verbose output #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix exception in case no charts were found in Markdown file - Log depending on type of input (Markdown or mermaid): Number of charts found in Markdown file - Add --quiet flag to suppress these new log message
|
Thanks for the PR. I will look into it this week (hopefully today). 馃槃 |
MindaugasLaganeckas
approved these changes
Sep 23, 2021
ghtyrant
added a commit
to ghtyrant/mermaid-cli
that referenced
this pull request
Sep 28, 2021
MindaugasLaganeckas
pushed a commit
that referenced
this pull request
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搼 Summary
found in Markdown file
String.matchreturns null if nothing was matched - the PR fixes handling this case.Also adds more log output that can be suppressed with
-q/--quiet.Explains in description for
--inputflag how .md files are treated.Resolves #160
馃搹 Design Decisions
Calling mermaid-cli on a Markdown file that does not contain mermaid charts should not crash the application. Neither should it report an error or return a non-null status code as it might break use cases where someone blindly runs it on a collection of Markdown files.
I did not apply the standard.js linter/formatter as the existing code base is not formatted either.
--quietsuppresses info but not error messages - not sure if that is desired behavior.馃搵 Tasks
Make sure you
masterbranch