Fix Markdown parsing, add more verbose output #165
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
found in Markdown file
String.match
returns null if nothing was matched - the PR fixes handling this case.Also adds more log output that can be suppressed with
-q/--quiet
.Explains in description for
--input
flag how .md files are treated.Resolves #160
📏 Design Decisions
Calling mermaid-cli on a Markdown file that does not contain mermaid charts should not crash the application. Neither should it report an error or return a non-null status code as it might break use cases where someone blindly runs it on a collection of Markdown files.
I did not apply the standard.js linter/formatter as the existing code base is not formatted either.
--quiet
suppresses info but not error messages - not sure if that is desired behavior.📋 Tasks
Make sure you
master
branch