Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Add an automated test for #165
Resolves #166
📏 Design Decisions
I simply run mmdc in a container, verify it doesn't crash and then compare its output to an expected value.
I'm not quite happy with this setup, as run_tests.sh is meant to be called with either test-positive or test-negative - this new test will run in both cases. I'd suggest removing the INPUT_DATA argument and hard-coding test-positive and test-negative.
📋 Tasks
Make sure you
master
branch