Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps-dev): bump mermaid from 10.1.0 to 10.2.0 #541

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 29, 2023

Bumps mermaid from 10.1.0 to 10.2.0.

Release notes

Sourced from mermaid's releases.

10.2.0

What's Changed

Features

Bugfixes

Documentation

Chores

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [mermaid](https://github.com/mermaid-js/mermaid) from 10.1.0 to 10.2.0.
- [Release notes](https://github.com/mermaid-js/mermaid/releases)
- [Changelog](https://github.com/mermaid-js/mermaid/blob/develop/CHANGELOG.md)
- [Commits](mermaid-js/mermaid@v10.1.0...v10.2.0)

---
updated-dependencies:
- dependency-name: mermaid
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels May 29, 2023
Copy link
Member

@aloisklink aloisklink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Percy changes look mostly good, with one exception:

image

Is this something we should bring up with the main Mermaid team?

@MindaugasLaganeckas
Copy link
Member

Can you bring it with the Mermaid project? If they do not respond within a couple of days, we will update the mermaid version in mermaid-cli and make a release. I do not think it is a blocker. In general, we do not want to fall behind with mermaid versions. Another thing, can we suggest the mermaid project to use Percy for their quality assurance? 😄 It is not the first time we catch a regression in the parent project 🧜‍♀️

@aloisklink
Copy link
Member

Can you bring it with the Mermaid project?

Reported as mermaid-js/mermaid#4455, I even found the commit that changed the behavior!

I do not think it is a blocker.

Yep, neither do I! I'm going to merge this PR now, although I suspect @dependabot will soon make a PR for Mermaid v10.2.2, since that has just come out. Would you be happy to make a release and publish everything to NPM>?

Another thing, can we suggest the mermaid project to use Percy for their quality assurance?

I think the problem is that they have too many images/changes to fall into the free tier of any SaaS visual regression product. They do use https://applitools.com/, but due to the small amount of API credits, they generally only do it right before release.

There's a PR to add some open-source visual regression testing using GitHub Actions (see mermaid-js/mermaid#3894), but IMO, it currently has a bunch of issues that makes it unlikely to be merged as it is.

@aloisklink aloisklink merged commit 883b825 into master Jun 4, 2023
11 of 12 checks passed
@aloisklink aloisklink deleted the dependabot/npm_and_yarn/mermaid-10.2.0 branch June 4, 2023 23:33
@MindaugasLaganeckas
Copy link
Member

Superb work!!! 😄

@aloisklink aloisklink mentioned this pull request Jun 11, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants