Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nginx-unprivileged #1220

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

enchant97
Copy link
Contributor

📑 Summary

This allows the Docker image to run as an unprivileged user instead of root.

Resolves #249

📏 Design Decisions

  • Changes nginx image to nginxinc/nginx-unprivileged
  • Keeps port on 80, as it's supported from Docker 20.03

📋 Tasks

Make sure you

This allows the Docker image to run as an unprivileged user, due to
changes in Docker; the port remains as 80.
@netlify
Copy link

netlify bot commented May 7, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit a8c0fb1
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/6457db5a2a7a280008b21101
😎 Deploy Preview https://deploy-preview-1220--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sidharthv96 sidharthv96 added this pull request to the merge queue May 9, 2023
@sidharthv96
Copy link
Member

Thanks @enchant97

Merged via the queue into mermaid-js:develop with commit b1bcc5a May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not run as root
2 participants