Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated changelog file #3022

Open
keikoro opened this issue May 9, 2022 · 5 comments
Open

outdated changelog file #3022

keikoro opened this issue May 9, 2022 · 5 comments
Labels
Status: Triage Needs to be verified, categorized, etc

Comments

@keikoro
Copy link

keikoro commented May 9, 2022

It looks to me like CHANGELOG.md, which is linked to from the README, is missing updates found in the release log.

I'm wondering if there are ways to have the file automatically be updated once a new release is published – not sure if there are any bots which can do that –, or if it would make sense to remove the file otherwise. (The thinking being it'd be better not to have the file at all rather than it being misleading if it gets overlooked on a more regular basis.)

@github-actions github-actions bot added the Status: Triage Needs to be verified, categorized, etc label May 9, 2022
@Yash-Singh1
Copy link
Member

Yash-Singh1 commented May 11, 2022

Yes, I agree, we should either:

  1. create a workflow that updates the changelog on release
  2. remove it all together

@knsv, what do you think we should do here?

@wolfspyre
Copy link

wolfspyre commented May 11, 2022 via email

@keikoro
Copy link
Author

keikoro commented May 11, 2022

I appreciate the thought but personally wouldn't want to have my Git author name and email address listed in a Changelog, tbh.

Addendum, I'm aware this is essentially publicly available (meta) data but the explicit surfacing via project docs would make me think twice about contributing to a project. GitHub user names can already be a pain but full name + email address goes a level beyond that, IMO. It's also not without reason that users can e.g. use different email addresses for different purposes on platforms like GitHub.

@knsv
Copy link
Collaborator

knsv commented Aug 21, 2022

@Yash-Singh1 I think we should remove it unless we find a way to manage it
@keikoro also have a good point.

@weedySeaDragon
Copy link
Contributor

There are tools that update changelogs and release notes that do not include emails (which I agree -- is not a good idea).
There are a number of GitHub actions devoted to doing exactly this. Some allow you to configure exactly what information is/is not included (e.g. by using tags/placeholders/interpolations).

Here's the most popular one currently on GitHub:
https://github.com/marketplace/actions/release-changelog-builder

All automated tools are going to require some sort of standardization; most (if not all) work off of PRs, so PRs have to be standardized. That's a small price to pay IMHO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc
Projects
None yet
Development

No branches or pull requests

5 participants