Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classdefs are not supported in external diagrams. #4818

Closed
sidharthv96 opened this issue Sep 7, 2023 · 0 comments · Fixed by #4819
Closed

Classdefs are not supported in external diagrams. #4818

sidharthv96 opened this issue Sep 7, 2023 · 0 comments · Fixed by #4819
Labels
Internals: Renderer Type: Bug / Error Something isn't working or is incorrect Type: Enhancement New feature or request

Comments

@sidharthv96
Copy link
Member

Description

The check with CLASSDEF_DIAGRAMS prevents external diagrams from using classes to style elements.

Steps to reproduce

N/A

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

No response

Additional Context

No response
@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Sep 7, 2023
sidharthv96 added a commit that referenced this issue Sep 7, 2023
@sidharthv96
fix: #4818 support getClasses in external diagrams.
38123d2
@sidharthv96 sidharthv96 mentioned this issue Sep 7, 2023
Merged
4 tasks
@sidharthv96 sidharthv96 added Type: Enhancement New feature or request Internals: Renderer and removed Status: Triage Needs to be verified, categorized, etc labels Sep 7, 2023
sidharthv96 added a commit to chadfawcett/mermaid that referenced this issue Sep 14, 2023
@sidharthv96
Merge branch 'develop' into pr/chadfawcett/4825
983cf45 
* develop:
  chore: Fix type in 'getLineFunctionsWithOffset'
  refactor: Add getLineFunctionsWithOffset function
  refactor: Move EdgeData to types
  fix: PointStart marker refX
  chore(deps): update all patch dependencies
  refactor: Fix typings in utils.ts
  chore: Add @internal to createCSSStyles
  chore: Bump version
  refactor: Remove unused variables
  fix: mermaid-js#4818 support `getClasses` in external diagrams.
sidharthv96 added a commit that referenced this issue Sep 14, 2023
@sidharthv96
Merge branch 'develop' into next
5aee43d 
* develop:
  Bump version
  chore: Fix type in 'getLineFunctionsWithOffset'
  Update cypress/platform/marker_unique_id.html
  refactor: Add getLineFunctionsWithOffset function
  refactor: Move EdgeData to types
  fix: PointStart marker refX
  Added cypress test
  chore(deps): update all patch dependencies
  refactor: Fix typings in utils.ts
  Give markers unique id's per graph
  chore: Add @internal to createCSSStyles
  chore: Bump version
  refactor: Remove unused variables
  fix: #4818 support `getClasses` in external diagrams.
sidharthv96 added a commit to Yokozuna59/mermaid that referenced this issue Sep 14, 2023
@sidharthv96
Merge branch 'next' into pr/Yokozuna59/4751
fedbd48 
* next: (98 commits)
  refactor: Simplify TokenBuilder and ValueConverter
  chore: Fix pnpm-lock
  Bump version
  chore: Fix type in 'getLineFunctionsWithOffset'
  Update cypress/platform/marker_unique_id.html
  refactor: Add getLineFunctionsWithOffset function
  refactor: Move EdgeData to types
  fix: PointStart marker refX
  Added cypress test
  chore(deps): update all patch dependencies
  refactor: Fix typings in utils.ts
  Give markers unique id's per graph
  chore: Fix type
  chore: Add @internal to createCSSStyles
  chore: Bump version
  refactor: Remove unused variables
  fix: mermaid-js#4818 support `getClasses` in external diagrams.
  Remove unnecessary tests
  Remove optional chaining
  chore: Update docs
  ...
sidharthv96 added a commit to rhysd/mermaid that referenced this issue Sep 14, 2023
@sidharthv96
Merge branch 'develop' into pr/rhysd/4359
0dbebe9 
* develop: (37 commits)
  fix: Arrow markers in flowchart-elk
  Bump version
  chore: Fix type in 'getLineFunctionsWithOffset'
  Update cypress/platform/marker_unique_id.html
  refactor: Add getLineFunctionsWithOffset function
  refactor: Move EdgeData to types
  fix: PointStart marker refX
  Added cypress test
  chore(deps): update all patch dependencies
  refactor: Fix typings in utils.ts
  Give markers unique id's per graph
  chore: Add @internal to createCSSStyles
  chore: Bump version
  refactor: Remove unused variables
  fix: mermaid-js#4818 support `getClasses` in external diagrams.
  Remove unnecessary tests
  Remove optional chaining
  chore: Update docs
  refactor: Use `||` instead of `??`
  Update flowchart.md (mermaid-js#4798)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Internals: Renderer Type: Bug / Error Something isn't working or is incorrect Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support ClassDefs in external diagrams mermaid-js/mermaid
1 participant
@sidharthv96