-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug/1061 Cannot mark members as protected in class diagram #1081
Bug/1061 Cannot mark members as protected in class diagram #1081
Conversation
Great, thanks for your contribution. According to our contribution docs, prs go into Your newly added unit test doesn't pass, you might want to look into that. |
Using # to indicate protected status of a member or method causing parser error when not used inside class declaration brackets {}. Removed '#' from `LABEL` regex
e2f00d0
to
68c2ea3
Compare
How can I run unit tests locally? Not finding anything in documentation... |
I fixed the syntax error in the failing test (duh), and now those are all fine. But I see that the GitHub builds failed.. I dont understand why, based on the messages provided though. |
This is not related to your code. We just introduced GitHub builds as a testing phase, for now travis matters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks neat! Good with improvements to the class diagrams. There is only one thing I would like to add is a render test as well. A render test really helps making sure things does not break without anyone noticing it.
It should not take more than a few minutes. Look at cypress\integration\rendering\classDiagram.spec.js
. Just copy a test and replace the diagram code with code showing your changes .
After this I will merge this. 🎉
@knsv Are you saying that you would rather there be a separate test? As opposed to just adding to an existing test which is what I had done :) Which does make sense |
Good work with this one! |
Using # to indicate protected status of a member or method causing parser error when not used inside class declaration brackets {}. Removed '#' from
LABEL
regexResolves #1061