Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup lint-staged and husky #2522

Merged
merged 5 commits into from
Dec 7, 2021
Merged

setup lint-staged and husky #2522

merged 5 commits into from
Dec 7, 2021

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 29, 2021

📑 Summary

Brief description about the content of your PR.

Resolves #1878

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link
Member

@Yash-Singh1 Yash-Singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! I just left a few comments below.

.lintstagedrc.json Outdated Show resolved Hide resolved
.husky/pre-commit Outdated Show resolved Hide resolved
Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.husky/pre-push Outdated Show resolved Hide resolved
Co-Authored-By: Yash Singh <saiansh2525@gmail.com>
@Yash-Singh1 Yash-Singh1 mentioned this pull request Dec 1, 2021
43 tasks
Copy link
Member

@Yash-Singh1 Yash-Singh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mmorel-35 mmorel-35 mentioned this pull request Dec 4, 2021
3 tasks
@knsv knsv merged commit bd106e4 into develop Dec 7, 2021
@knsv knsv deleted the eslint-husky branch December 7, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a pre-commit lint hook for staged files.
4 participants