Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add accessibility title and description to pie chart #2747

Merged
merged 1 commit into from Feb 24, 2022
Merged

feat: add accessibility title and description to pie chart #2747

merged 1 commit into from Feb 24, 2022

Conversation

gwincr11
Copy link
Contributor

@gwincr11 gwincr11 commented Feb 18, 2022 •
edited

馃搼 Summary

  • Reuse the title as the title element
  • Add description to the parser and then render
  • Adds aria-label-by and role of img.

Screen Shot 2022-02-17 at 9 55 56 PM

Resolves #

馃搹 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@gwincr11 gwincr11 closed this Feb 18, 2022
@gwincr11 gwincr11 reopened this Feb 18, 2022
@gwincr11
feat: add accessibility title and description to pie chart
0b815c7 
* Reuse the title as the title element
* Add description to the parser and then render
@gwincr11 gwincr11 marked this pull request as ready for review February 23, 2022 02:43
@gwincr11 gwincr11 mentioned this pull request Feb 23, 2022
Closed
9 tasks
ashishjain0512
ashishjain0512 approved these changes Feb 24, 2022
View reviewed changes
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution

@ashishjain0512 ashishjain0512 merged commit 908b704 into mermaid-js:develop Feb 24, 2022
@gwincr11 gwincr11 deleted the cg-pie-chart-accessibility branch February 24, 2022 18:29
@therzka therzka mentioned this pull request Apr 8, 2022
Merged
3 tasks
@knsv knsv mentioned this pull request May 6, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishjain0512 ashishjain0512 ashishjain0512 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gwincr11 @ashishjain0512