Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2732 accesible charts #3008

Merged
merged 15 commits into from
May 6, 2022
Merged

2732 accesible charts #3008

merged 15 commits into from
May 6, 2022

Conversation

knsv
Copy link
Collaborator

@knsv knsv commented May 6, 2022

📑 Summary

Adds a title and accDescription to diagrams to improve accessibility. This updates the existing work done in PRs:
#2747
#2832
#2911
#2912
#2913
#2915
#2916
#2917
#2919

Resolves #2732

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to streamline these for all the diagrams

@ashishjain0512 ashishjain0512 merged commit da548f1 into develop May 6, 2022
@mmorel-35
Copy link
Contributor

Since this commit, the linting is failing, can you take a look :) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More Accessible Mermaid Charts
3 participants