WIP: Remove webpack & babel #3467
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: (40 commits) chore(deps-dev): bump typescript from 4.8.2 to 4.8.3 (#3446) chore(deps): bump actions/checkout from 2 to 3 (#3449) change wording of console log message (use comma) Moving out tests from mermaid.spec.js Fix for issue with setting the loglevel via numbers chore: update browsers list Limiting the interaction between the mermaid diagram and Mermaid to the diagramAPI Fix for broken tests chore(docs): Remove edit this page fix(git): support unusual prefixes in branch name formatting eslint fixes Creating detectors and moving out diagram specific code from the diagramAPI add eslint-disable no-console for file fix: Run precommit hook for doc.mts changes too chore: Updated doc files fix: Formatting issue (formatting only) sort imports just to force a new CI lint check ci: re-enable coveralls coverage upload build(dev-deps): remove unused `coveralls` ...
* sidv/mergeRelease: chore(deps-dev): bump eslint-plugin-jest from 27.0.1 to 27.0.4 (#3458) chore(deps-dev): bump @typescript-eslint/eslint-plugin (#3457) chore(deps-dev): bump concurrently from 7.3.0 to 7.4.0 (#3445) chore(deps-dev): bump @babel/preset-env from 7.18.10 to 7.19.0 (#3442) chore(deps-dev): bump @typescript-eslint/parser from 5.36.1 to 5.37.0 (#3451) chore(deps-dev): bump @babel/core from 7.18.13 to 7.19.0 (#3447) chore(deps-dev): bump jest-environment-jsdom from 29.0.2 to 29.0.3 (#3441) chore(deps-dev): bump babel-jest from 29.0.2 to 29.0.3 (#3448) chore(deps-dev): bump eslint from 8.23.0 to 8.23.1 Release 9.1.7 Fix for broken rendering test Fix for issue #3428, load the configured diagrams even when initialize has not been called.
* sidv/esbuild: Remove extension
* sidv/esbuild: chore(deps): bump dompurify from 2.3.10 to 2.4.0 (#3444) chore(deps): bump stylis from 4.1.1 to 4.1.2 (#3439) chore(deps-dev): bump webpack-dev-server from 4.10.1 to 4.11.0 (#3450) Cleanup fixing som lingering issues Apply suggestions from code review chore: fix eslint warnings chore: Turn off eslint rules in spec, demos, etc.
sidharthv96
commented
Sep 15, 2022
Comment on lines
+86
to
+88
| footer: { | ||
| js: 'mermaid = mermaid.default;', | ||
| }, |
There was a problem hiding this comment.
@aloisklink this is a hack I tried out to fix mermaid.initialize is not a function.
We need to figure out the root cause on why it's not emitted properly.
There was a problem hiding this comment.
Hmmmm, I wonder if it's a TypeScript issue, I vaguely remember having similar issues when converting CommonJS code using module.exports = example;, see microsoft/TypeScript#2719
There was a problem hiding this comment.
Webpack is handling it somehow.
* develop: cleanup Fix docs Fix coverage Fix for issues in errorhandling and class diagrams after refactoring Replace GoogleAnalytics with Plausible fix(git): support single character branch names Cleanup unused variables and some commented out code ci(e2e): re-enable e2e tests style: fix .github/workflow/e2e styling chore: upgrade cypress to v10 fix(flowchart-v2): fix arrowMarkerAbsolute=true test(e2e): fix most arrowMarkerAbsolute tests text(e2e): give git tests consistent commit id test(e2e): widen flowchart width to within 10% test(e2e): fix failing xss9 test
sidharthv96
changed the base branch from
sidv/esbuild
to
sidv/removeWebpackBabel
sidharthv96
changed the base branch from
sidv/removeWebpackBabel
to
develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃搼 Summary
Uses esbuild as the build and dev tool.
馃搹 Design Decisions
Uses express to serve multiple static dirs and proxy requests to iife and esm versions of esbuild.
馃搵 Tasks
Make sure you
developbranch