fix(class): keep members in namespace classes

[tomperr]

📑 Summary

Keep members of classes in namespaces, whether relations are defined before or after classes definition

Resolves #4519

📏 Design Decisions

We keep all classes (including the ones inside a namespace) inside classes dictionary so we don't consider them as undefined

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added unit/e2e tests (if appropriate)
• 📓 have added documentation (if appropriate)
• 🔖 targeted develop branch

[codecov-commenter]

Codecov Report

Merging #4532 (47db1a3) into develop (ecc5289) will increase coverage by 2.93%.
The diff coverage is 82.35%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #4532      +/-   ##
===========================================
+ Coverage    81.01%   83.95%   +2.93%     
===========================================
  Files          136      136              
  Lines        10446    10445       -1     
  Branches       492      491       -1     
===========================================
+ Hits          8463     8769     +306     
+ Misses        1829     1529     -300     
+ Partials       154      147       -7     

Flag	Coverage Δ
e2e	83.83% <82.35%> (+2.94%)	⬆️
unit	28.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ges/mermaid/src/diagrams/class/classRenderer-v2.ts	79.85% <81.25%> (-0.15%)	⬇️
packages/mermaid/src/diagrams/class/classDb.ts	73.79% <100.00%> (-9.19%)	⬇️

... and 36 files with indirect coverage changes

[sidharthv96]

Suggested change

	let cssClassStr = '';
	if (vertex.cssClasses.length > 0) {
	cssClassStr = cssClassStr + ' ' + vertex.cssClasses.join(' ');
	}
	const cssClassStr = vertex.cssClasses.join(' ');

[sidharthv96]

This is not modified afterwards. Bug?

[sidharthv96]

Avoid magic number 500

[tomperr]

@sidharthv96 seems like there is a bug on this PR, the only thing I added in classRenderer-v2.ts was the filter before the foreach loop

[tomperr]

There might be some lines of code in this file that need to be reworked, but I don't think this should be done in this PR (as it is not linked to the issue + I am not the author of the code you commented)