chore: Preview PRs with mermaid-live-editor on Netlify #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4769 +/- ##
============================================
+ Coverage 45.55% 74.76% +29.20%
============================================
Files 53 146 +93
Lines 6629 14569 +7940
Branches 32 592 +560
============================================
+ Hits 3020 10892 +7872
+ Misses 3608 3559 -49
- Partials 1 118 +117
Flags with carried forward coverage won't be shown. Click here to find out more. |
nirname
approved these changes
Aug 24, 2023
Yokozuna59
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
LGTM, it's has no errors or warnings when running shellcheck.
But I think we could also create the editor locally. Making this script execute on PR would help to reviewers to test changes on grammar, but I think it would be great also to let developers test those changes on an editor instead manual execution of unit/integration tests.
aloisklink
approved these changes
Aug 24, 2023
nirname
reviewed
Aug 24, 2023
sidharthv96
changed the title
Co-authored-by: Alois Klink <alois@aloisklink.com>
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Aug 28, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://togithub.com/mermaid-js/mermaid) | [`10.3.1` -> `10.4.0`](https://renovatebot.com/diffs/npm/mermaid/10.3.1/10.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.4.0`](https://togithub.com/mermaid-js/mermaid/releases/tag/v10.4.0) [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v10.3.1...v10.4.0) #### Features - feat: Support config in frontmatter. by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4750 - feat(sankey): Show values by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4748 #### Docs - docs: Add development example page. by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4714 - Documentation for [#​2509](https://togithub.com/mermaid-js/mermaid/issues/2509) by [@​jason-curtis](https://togithub.com/jason-curtis) in [mermaid-js/mermaid#4740 - Fixes to Docs sidebar, main page and badges by [@​nirname](https://togithub.com/nirname) in [mermaid-js/mermaid#4742 - Split development documentation into several pages by [@​nirname](https://togithub.com/nirname) in [mermaid-js/mermaid#4744 - Docs: update Latest News section by [@​huynhicode](https://togithub.com/huynhicode) in [mermaid-js/mermaid#4768 #### Chores - Update all minor dependencies (minor) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4732 - Update all patch dependencies (patch) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4731 - convert `assignWithDepth` to TS by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4717 - convert `diagrams/common/svgDrawCommon.js` to ts by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4724 - ci(release-drafter): add more release notes categories by [@​aloisklink](https://togithub.com/aloisklink) in [mermaid-js/mermaid#4752 - chore(deps): update all patch dependencies (patch) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#4753 - standardized pie definitions by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#4501 - Remove Circular Dependencies by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4761 - chore: Enforce type imports by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4763 - chore: Preview PRs with mermaid-live-editor on Netlify by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#4769 #### New Contributors - [@​jason-curtis](https://togithub.com/jason-curtis) made their first contribution in [mermaid-js/mermaid#4740 **Full Changelog**: mermaid-js/mermaid@v10.3.1...v10.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNTYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
We will now deploy a live editor preview for develop, next, master branches and all PRs.
This should make reviews easier for the maintainers.
Implements #3348
📏 Design Decisions
We can try adding live editor as a git submodule.
But I would rather not make any changes to the mermaid repo right now, apart from adding one file.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch