Feature/4653 add actor-top class to sequence diagram #5241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5241 +/- ##
============================================
+ Coverage 43.21% 79.47% +36.26%
============================================
Files 23 167 +144
Lines 5033 13907 +8874
Branches 23 710 +687
============================================
+ Hits 2175 11053 +8878
+ Misses 2857 2702 -155
- Partials 1 152 +151
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sidharthv96
requested changes
Jan 26, 2024
There was a problem hiding this comment.
Nice work!
Should we add an actor-bottom class as well in the footer?
An integration test to verify the class has been added is required. You can do an imgSnapshotTest, and check that the class has been added using a check similar to
cy.get('.actor-top').should('have.text', '<Name of actor>');
You can add this line to any existing test, that's fine. No need for a new test.
|
@sidharthv96 I agree that adding a As per the integration test, adding a new one seemed cleaner to me, tested both scenarios of rectangle actor and man actor. |
…feature/4653-add_actor-top_class_to_sequence_diagram
|
Yes, can you please add bottom as well? |
…feature/4653-add_actor-top_class_to_sequence_diagram
|
added |
sidharthv96
approved these changes
Jan 30, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Ronid1
deleted the
feature/4653-add_actor-top_class_to_sequence_diagram
branch
fuxingloh
pushed a commit
to fuxingloh/contented
that referenced
this pull request
Feb 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://togithub.com/mermaid-js/mermaid) | [`10.7.0` -> `10.8.0`](https://renovatebot.com/diffs/npm/mermaid/10.7.0/10.8.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.8.0`](https://togithub.com/mermaid-js/mermaid/releases/tag/v10.8.0) [Compare Source](https://togithub.com/mermaid-js/mermaid/compare/v10.7.0...v10.8.0) ### v10.8.0 #### Features <img width="375" alt="image" src="https://github.com/mermaid-js/mermaid/assets/5837277/c17405fb-2a06-4f7c-9c77-5eaba6c76747"> - Adding new diagram type - Block Diagram by [@​knsv](https://togithub.com/knsv) in [mermaid-js/mermaid#5221 - Feature/5114 add parallel commit config by [@​mathbraga](https://togithub.com/mathbraga) in [mermaid-js/mermaid#5161 - Changes to Gantt Parsers to allow hashes and semicolons to titles, sections, and task data. by [@​FutzMonitor](https://togithub.com/FutzMonitor) in [mermaid-js/mermaid#5095 - Feature/4653 add actor-top class to sequence diagram by [@​Ronid1](https://togithub.com/Ronid1) in [mermaid-js/mermaid#5241 #### Documentation - Updated gantt chart docs to show all config options by [@​murdoa](https://togithub.com/murdoa) in [mermaid-js/mermaid#5192 - Contribution documentation improvements by [@​nirname](https://togithub.com/nirname) in [mermaid-js/mermaid#5132 - Update flowchart.md - how to use font-awesome [#​5195](https://togithub.com/mermaid-js/mermaid/issues/5195) by [@​arukiidou](https://togithub.com/arukiidou) in [mermaid-js/mermaid#5196 - Add more detailed docs for Gantt tasks by [@​sorenisanerd](https://togithub.com/sorenisanerd) in [mermaid-js/mermaid#5194 - Docs/4974 reorder integration links by [@​Ronid1](https://togithub.com/Ronid1) in [mermaid-js/mermaid#5066 - docs: fix swimm link by [@​Yokozuna59](https://togithub.com/Yokozuna59) in [mermaid-js/mermaid#5219 - Update Slack community links to Discord by [@​Olegt0rr](https://togithub.com/Olegt0rr) in [mermaid-js/mermaid#5225 - Docs: Mermaid chart updates by [@​huynhicode](https://togithub.com/huynhicode) in [mermaid-js/mermaid#5232 - Fix typos in timeline syntax samples by [@​sblom](https://togithub.com/sblom) in [mermaid-js/mermaid#5139 #### Bug fixes - Bug/5059 fix external connection after updating edges by [@​mathbraga](https://togithub.com/mathbraga) in [mermaid-js/mermaid#5127 - \[Fix] Sequence diagram actor menu popup by [@​vitorsss](https://togithub.com/vitorsss) in [mermaid-js/mermaid#5160 - fix: Dompurify Hooks by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5236 - Accurate pie chart labeling for text alignment by [@​JenningsWilliam](https://togithub.com/JenningsWilliam) in [mermaid-js/mermaid#5141 - fix: Redirect of old URLs by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5250 - Fixed Typo in ErrorRenderer.ts by [@​FutzMonitor](https://togithub.com/FutzMonitor) in [mermaid-js/mermaid#5256 #### Chores - Revert "Revert 5041 feature/4935 subgraph title margin config option" by [@​mathbraga](https://togithub.com/mathbraga) in [mermaid-js/mermaid#5205 - build(deps-dev): bump follow-redirects from 1.15.2 to 1.15.5 by [@​dependabot](https://togithub.com/dependabot) in [mermaid-js/mermaid#5200 - chore(deps): update all patch dependencies (patch) by [@​renovate](https://togithub.com/renovate) in [mermaid-js/mermaid#5150 - E2E Image comparison by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5208 - E2E test by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5210 - Optimise caching of test results by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5213 - Update update-browserlist.yml to fix deprecation and action fails by [@​Abrifq](https://togithub.com/Abrifq) in [mermaid-js/mermaid#5151 - UpdateCypress by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5228 - Use node v20 by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5248 - Convert Mindmap to TS by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5247 - chore: Add interface naming Convention by [@​sidharthv96](https://togithub.com/sidharthv96) in [mermaid-js/mermaid#5254 #### New Contributors - [@​murdoa](https://togithub.com/murdoa) made their first contribution in [mermaid-js/mermaid#5192 - [@​arukiidou](https://togithub.com/arukiidou) made their first contribution in [mermaid-js/mermaid#5196 - [@​sorenisanerd](https://togithub.com/sorenisanerd) made their first contribution in [mermaid-js/mermaid#5194 - [@​Ronid1](https://togithub.com/Ronid1) made their first contribution in [mermaid-js/mermaid#5066 - [@​Olegt0rr](https://togithub.com/Olegt0rr) made their first contribution in [mermaid-js/mermaid#5225 - [@​vitorsss](https://togithub.com/vitorsss) made their first contribution in [mermaid-js/mermaid#5160 - [@​sblom](https://togithub.com/sblom) made their first contribution in [mermaid-js/mermaid#5139 - [@​JenningsWilliam](https://togithub.com/JenningsWilliam) made their first contribution in [mermaid-js/mermaid#5141 **Full Changelog**: mermaid-js/mermaid@v10.7.0...v10.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjE1My4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Added
actor-topclass to top-level actor boxes and actor figures in sequence diagram.Resolves #4653
📏 Design Decisions
For the rectangle actors, added the
actor-topclass to the rectangleFor the man figure actors, added the
actor-topclass to the<g>wrapper📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.developbranch